fix(tools): pass provider runtime model by reference
Resolves clippy::needless_pass_by_value in tools/lib.rs. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
parent
1e8e152148
commit
6a01aa52e6
1 changed files with 3 additions and 3 deletions
|
|
@ -1632,7 +1632,7 @@ fn build_agent_runtime(
|
||||||
.clone()
|
.clone()
|
||||||
.unwrap_or_else(|| DEFAULT_AGENT_MODEL.to_string());
|
.unwrap_or_else(|| DEFAULT_AGENT_MODEL.to_string());
|
||||||
let allowed_tools = job.allowed_tools.clone();
|
let allowed_tools = job.allowed_tools.clone();
|
||||||
let api_client = ProviderRuntimeClient::new(model, allowed_tools.clone())?;
|
let api_client = ProviderRuntimeClient::new(&model, allowed_tools.clone())?;
|
||||||
let tool_executor = SubagentToolExecutor::new(allowed_tools);
|
let tool_executor = SubagentToolExecutor::new(allowed_tools);
|
||||||
Ok(ConversationRuntime::new(
|
Ok(ConversationRuntime::new(
|
||||||
Session::new(),
|
Session::new(),
|
||||||
|
|
@ -1809,8 +1809,8 @@ struct ProviderRuntimeClient {
|
||||||
}
|
}
|
||||||
|
|
||||||
impl ProviderRuntimeClient {
|
impl ProviderRuntimeClient {
|
||||||
fn new(model: String, allowed_tools: BTreeSet<String>) -> Result<Self, String> {
|
fn new(model: &str, allowed_tools: BTreeSet<String>) -> Result<Self, String> {
|
||||||
let model = resolve_model_alias(&model).to_string();
|
let model = resolve_model_alias(model).to_string();
|
||||||
let client = ProviderClient::from_model(&model).map_err(|error| error.to_string())?;
|
let client = ProviderClient::from_model(&model).map_err(|error| error.to_string())?;
|
||||||
Ok(Self {
|
Ok(Self {
|
||||||
runtime: tokio::runtime::Runtime::new().map_err(|error| error.to_string())?,
|
runtime: tokio::runtime::Runtime::new().map_err(|error| error.to_string())?,
|
||||||
|
|
|
||||||
Loading…
Add table
Reference in a new issue